Luka-J9 commented on code in PR #1246:
URL: https://github.com/apache/pekko-connectors/pull/1246#discussion_r2437550052
##########
s3/src/test/scala/docs/scaladsl/S3SinkSpec.scala:
##########
@@ -286,7 +294,9 @@ class S3SinkSpec extends S3WireMockBase with
S3ClientIntegrationSpec with Option
.withHeader(sseCKeyHeader, new EqualToPattern(sseCKeyHeaderValue))
.withHeader(sseCSourceAlgorithmHeader, new
EqualToPattern(sseCSourceAlgorithmHeaderValue))
.withHeader(sseCSourceKeyHeader, new
EqualToPattern(sseCSourceKeyHeaderValue))
- .withHeader(requestPayerHeader, new
EqualToPattern(requestPayerHeaderValue)))
+ .withHeader(requestPayerHeader, new
EqualToPattern(requestPayerHeaderValue))
Review Comment:
This is showing the correct outcome, but with the change in S3Stream.scala
we remove the valid header of `requestPayerHeaderValue`. Without it we get
illegal `storageClassHeader`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
