Luka-J9 commented on code in PR #1246:
URL: https://github.com/apache/pekko-connectors/pull/1246#discussion_r2437547310
##########
s3/src/test/scala/docs/scaladsl/S3SinkSpec.scala:
##########
@@ -263,7 +265,13 @@ class S3SinkSpec extends S3WireMockBase with
S3ClientIntegrationSpec with Option
targetBucketKey,
s3Headers = S3Headers()
.withServerSideEncryption(keys)
- .withCustomHeaders(Map(requestPayerHeader ->
requestPayerHeaderValue)))
+ .withCustomHeaders(
+ Map(
+ requestPayerHeader -> requestPayerHeaderValue,
+ storgeClassHeader -> storageClassHeaderValue,
Review Comment:
This adds the header that is valid for creating the multipart copy request,
but _is not valid_ for the put requests
[Docs list all valid headers
here](https://docs.aws.amazon.com/AmazonS3/latest/API/API_UploadPartCopy.html#API_UploadPartCopy_RequestSyntax)
I realize that there is also the storage class header value, but it also
doesn't include all valid header values which is why I'm adding it this way.
Additionally looking at the code it appears the behavior would be the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
