pjfanning commented on PR #2148: URL: https://github.com/apache/pekko/pull/2148#issuecomment-3333052773
> @pjfanning I just checked pekko-http, where `scanHeaderNameAndReturnIndexOfColon` should be replaced with `indexOf` I think, so does the `scanHeaderValue` That HttpHeaderParser class might possibly benefit from using ByteString indexOf but I suspect we will need a new overload for indexOf that allows you to specify from and to for the search. So far, we only support an overload that takes a from location. So we have: ``` def indexOf(b: Byte) def indexOf(b: Byte, from: Int) def indexOf(b: Byte, from: Int, to: Int) // new API that we can use in scanHeaderNameAndReturnIndexOfColon ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
