pjfanning commented on code in PR #2334:
URL: https://github.com/apache/pekko/pull/2334#discussion_r2443345773
##########
stream/src/main/scala/org/apache/pekko/stream/javadsl/Sink.scala:
##########
@@ -214,6 +214,20 @@ object Sink {
def asPublisher[T](fanout: AsPublisher): Sink[T, Publisher[T]] =
new Sink(scaladsl.Sink.asPublisher(fanout == AsPublisher.WITH_FANOUT))
+ /**
+ * A `Sink` that materializes this `Sink` itself as a `Source`.
+ * The returned `Source` is a "live view" onto the `Sink` and only supports
a single `Subscriber`.
+ *
+ * Use [[BroadcastHub#sink]] if you need a `Source` that allows multiple
subscribers.
+ *
+ * Note: even if the `Source` is directly connected to the `Sink`, there is
still an asynchronous boundary
+ * between them; performance may be improved in the future.
+ *
+ * @since 2.0.0
Review Comment:
needs to be 1.3.0 and this then needs to be updated in main branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
