mdedetrich commented on PR #2479: URL: https://github.com/apache/pekko/pull/2479#issuecomment-3522987602
> One possible 1.x solution would to leave the existing ActorSystem class as is except maybe to deprecate its methods. You can add new Scala and Java DSL classes that delegate to the existing class but that implement their own APIs and Autocloseable. The issue is that even doing this doesn't work at least without a huge amount of code churn. Direct inheritance doesn't work (as described) and delegation also won't work for other reasons, a lot of Actor code expects to work with `pekko.actor.ActorSystem` (or one of its subclasses) and so delegation won't work here. Regarding `AutoCloseable`, I made a PR at https://github.com/apache/pekko/pull/2486. The `AutoCloseable` interface is not reliant on scala/java dsl in any way so that can be implemented irrespective of https://github.com/apache/pekko/issues/2093 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
