marcopaggioro commented on code in PR #363:
URL:
https://github.com/apache/pekko-persistence-jdbc/pull/363#discussion_r2520065506
##########
core/src/test/scala/org/apache/pekko/persistence/jdbc/state/scaladsl/StateSpecBase.scala:
##########
@@ -47,13 +47,11 @@ abstract class StateSpecBase(val config: Config,
schemaType: SchemaType)
implicit lazy val e: ExecutionContext = system.dispatcher
private[jdbc] def schemaTypeToProfile(s: SchemaType) = s match {
- case H2 => slick.jdbc.H2Profile
- case Postgres => slick.jdbc.PostgresProfile
- // TODO https://github.com/apache/pekko-persistence-jdbc/issues/174
- // case MySQL => slick.jdbc.MySQLProfile
+ case H2 => slick.jdbc.H2Profile
+ case Postgres => slick.jdbc.PostgresProfile
+ case MySQL => slick.jdbc.MySQLProfile
case SqlServer => slick.jdbc.SQLServerProfile
case Oracle => slick.jdbc.OracleProfile
- case _ => throw new UnsupportedOperationException(s"Unsupported
<$s> for durableState.")
Review Comment:
If a new DBMS is added, isn't it easier to have a non-exhaustive match
reported by the IDE (and even some plugins) rather than a `case _` that would
hide it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
