mdedetrich commented on PR #1246: URL: https://github.com/apache/pekko-connectors/pull/1246#issuecomment-3526646095
> > > > @Luka-J9 I just ran the CI and some S3 tests failed, would you be able to look into it? > > > > > > > > > Looks like one of my tests is not compatible with scala 3 - it uses reflection to get a list of members of a sealed trait - I'll see if I can work around it > > > > > > There are open source libraries that target both Scala 2 and Scala 3 which can do this (i.e. https://github.com/zio/izumi-reflect), albeit this can be considered a bit excessive. > > If you do decide to use this library make sure to add the dependency only to `test` scope as we don't need as part of main s3. > > Opted to use exhaustivity checking - it should be good for another CI run now 🤞 Code is not formatted, format with scalafmt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
