He-Pin commented on code in PR #365:
URL:
https://github.com/apache/pekko-persistence-jdbc/pull/365#discussion_r2528433923
##########
core/src/main/scala/org/apache/pekko/persistence/jdbc/testkit/internal/SchemaUtilsImpl.scala:
##########
@@ -158,22 +156,26 @@ private[jdbc] object SchemaUtilsImpl {
private def dropScriptFor(schemaType: SchemaType, legacy: Boolean): (String,
String) = {
val suffix = if (legacy) "-legacy" else ""
schemaType match {
- case Postgres => (s"schema/postgres/postgres-drop-schema$suffix.sql",
";")
- case MySQL => (s"schema/mysql/mysql-drop-schema$suffix.sql", ";")
- case Oracle => (s"schema/oracle/oracle-drop-schema$suffix.sql", "/")
- case SqlServer => (s"schema/sqlserver/sqlserver-drop-schema$suffix.sql",
";")
- case H2 => (s"schema/h2/h2-drop-schema$suffix.sql", ";")
+ case Postgres =>
(s"schema/postgres/postgres-drop-schema$suffix.sql", ";")
+ case MySQL => (s"schema/mysql/mysql-drop-schema$suffix.sql",
";")
+ case MariaDB if legacy => throw new IllegalArgumentException(s"Invalid
legacy schema request for $schemaType")
+ case MariaDB =>
(s"schema/mariadb/mariadb-drop-schema$suffix.sql", ";")
+ case Oracle =>
(s"schema/oracle/oracle-drop-schema$suffix.sql", "/")
+ case SqlServer =>
(s"schema/sqlserver/sqlserver-drop-schema$suffix.sql", ";")
+ case H2 => (s"schema/h2/h2-drop-schema$suffix.sql", ";")
}
}
private def createScriptFor(schemaType: SchemaType, legacy: Boolean):
(String, String) = {
val suffix = if (legacy) "-legacy" else ""
schemaType match {
- case Postgres => (s"schema/postgres/postgres-create-schema$suffix.sql",
";")
- case MySQL => (s"schema/mysql/mysql-create-schema$suffix.sql", ";")
- case Oracle => (s"schema/oracle/oracle-create-schema$suffix.sql", "/")
- case SqlServer =>
(s"schema/sqlserver/sqlserver-create-schema$suffix.sql", ";")
- case H2 => (s"schema/h2/h2-create-schema$suffix.sql", ";")
+ case Postgres =>
(s"schema/postgres/postgres-create-schema$suffix.sql", ";")
+ case MySQL =>
(s"schema/mysql/mysql-create-schema$suffix.sql", ";")
+ case MariaDB if legacy => throw new IllegalArgumentException(s"Invalid
legacy schema request for $schemaType")
+ case MariaDB =>
(s"schema/mariadb/mariadb-create-schema$suffix.sql", ";")
+ case Oracle =>
(s"schema/oracle/oracle-create-schema$suffix.sql", "/")
+ case SqlServer =>
(s"schema/sqlserver/sqlserver-create-schema$suffix.sql", ";")
+ case H2 => (s"schema/h2/h2-create-schema$suffix.sql", ";")
Review Comment:
add a default case with explicit exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
