marcopaggioro commented on code in PR #366:
URL:
https://github.com/apache/pekko-persistence-jdbc/pull/366#discussion_r2529919202
##########
core/src/main/scala/org/apache/pekko/persistence/jdbc/state/SequenceNextValUpdater.scala:
##########
@@ -90,6 +90,18 @@ import slick.sql.SqlStreamingAction
String]
}
+/**
+ * INTERNAL API
+ */
+@InternalApi private[jdbc] final class MySQLSequenceNextValUpdater(profile:
JdbcProfile)
+ extends SequenceNextValUpdater {
+
+ import profile.api._
+
+ def getSequenceNextValueExpr() =
+ sql"""SELECT LAST_INSERT_ID()""".as[String]
Review Comment:
For your information, I double-checked my previous comment, and it seems
correct to me.
In addition, there are three tests run for each DBMS that specifically test
parallel upserts with 1,000 records.
Tests that begin with "A JDBC durable state store in the face of parallel
upserts."
These tests use shared-db, and I'm also adding those without shared-db.
As usual, not deterministic, but useful: I ran the same tests described here
https://github.com/apache/pekko-persistence-jdbc/pull/365#issuecomment-3533587412
on a 3-node cluster.
All green.
I'm also adding the option to choose whether to use LAST_INSERT_ID or the
classic SELECT id with related tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
