mdedetrich commented on PR #2560: URL: https://github.com/apache/pekko/pull/2560#issuecomment-3649841319
> I'm still suspicious about this and other recent performance oriented changes. They introduce more checks which reduces performance. These checks include instanceof checks which are not trivial. The performance gains are not proven. No microbenchmarks, etc. I haven't looked into the details of this PR, but from what I can tell its just doing specialization which in general is fine premise especially with data structures that time time to initialize/have an expensive initial cost. Having 0/1/2 sized streams is very common (2 sized streams is common due to tuples which `SubFlow`/`SubSource` use internally) so this can provide real benefits -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
