raboof commented on code in PR #597:
URL: https://github.com/apache/pekko-grpc/pull/597#discussion_r2715933122
##########
sbt-plugin/src/sbt-test/scala3/02-scala3-sourcegen/src/main/protobuf/helloworld.proto:
##########
@@ -0,0 +1,35 @@
+syntax = "proto3";
+
+import "scalapb/scalapb.proto";
+
+option java_multiple_files = true;
+option java_package = "example.myapp.helloworld.grpc";
+option java_outer_classname = "HelloWorldProto";
+
+option (scalapb.options) = {
+ scala3_sources: true
Review Comment:
right, so `scala3/01-basic-client-server` ran with Scala 3 but without this
option, generating Scala 2-compatible sources? That makes sense I suppose -
valuable to also have a scripted test that actually exercises the Scala 3
sources imo!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
