Copilot commented on code in PR #2656:
URL: https://github.com/apache/pekko/pull/2656#discussion_r2777633543
##########
stream-tests/src/test/scala/org/apache/pekko/stream/io/TlsSpec.scala:
##########
@@ -447,11 +440,11 @@ class TlsSpec extends StreamSpec(TlsSpec.configOverrides)
with WithLogCapturing
.collect { case SessionBytes(_, b) => b }
.scan(ByteString.empty)(_ ++ _)
.filter(_.nonEmpty)
- .via(new Timeout(10.seconds))
+ .via(new Timeout(15.seconds))
.dropWhile(_.size < scenario.output.size)
.runWith(Sink.headOption)
- Await.result(output,
12.seconds).getOrElse(ByteString.empty).utf8String should
be(scenario.output.utf8String)
+ Await.result(output,
17.seconds).getOrElse(ByteString.empty).utf8String should
be(scenario.output.utf8String)
Review Comment:
These new timeouts are still hard-coded and don’t use
`TestDuration.dilated`, while other time-based assertions in this spec do (e.g.
later in the file). Using `dilated` here as well would keep timing consistent
across slow/CI environments and avoid flakiness when the test time factor is
adjusted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
