sbmpost commented on code in PR #1152:
URL: https://github.com/apache/pekko-connectors/pull/1152#discussion_r2782467092
##########
mqtt-streaming/src/main/scala/org/apache/pekko/stream/connectors/mqtt/streaming/model.scala:
##########
@@ -819,7 +822,7 @@ object MqttCodec {
v.decodeSubAck(l)
case (ControlPacketType.UNSUBSCRIBE,
ControlPacketFlags.ReservedUnsubscribe) =>
v.decodeUnsubscribe(l)
- case (ControlPacketType.UNSUBACK,
ControlPacketFlags.ReservedUnsubAck) =>
+ case (ControlPacketType.UNSUBACK,
ControlPacketFlags.ReservedGeneral) =>
v.decodeUnsubAck()
Review Comment:
Both sides making the same error certainly is a possibility. However it was
already suggested that this would be detected once testing against a known good
broken implementation. It is not part of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
