[ 
https://issues.apache.org/jira/browse/RYA-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336291#comment-15336291
 ] 

ASF GitHub Bot commented on RYA-51:
-----------------------------------

Github user pujav65 commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/48#discussion_r67527212
  
    --- Diff: 
dao/mongodb.rya/src/main/java/mvm/rya/mongodb/MongoDBQueryEngine.java ---
    @@ -44,153 +52,144 @@
     import mvm.rya.mongodb.iter.RyaStatementCursorIterable;
     import mvm.rya.mongodb.iter.RyaStatementCursorIterator;
     
    -import org.calrissian.mango.collect.CloseableIterable;
    -import org.openrdf.query.BindingSet;
    -
    -import com.mongodb.DB;
    -import com.mongodb.DBCollection;
    -import com.mongodb.DBObject;
    -import com.mongodb.MongoClient;
    -
     /**
      * Date: 7/17/12
      * Time: 9:28 AM
      */
     public class MongoDBQueryEngine implements 
RyaQueryEngine<MongoDBRdfConfiguration>, Closeable {
     
         private MongoDBRdfConfiguration configuration;
    -   private MongoClient mongoClient;
    -   private DBCollection coll;
    -   private MongoDBStorageStrategy strategy;
    -    
    -    public MongoDBQueryEngine(MongoDBRdfConfiguration conf) throws 
NumberFormatException, UnknownHostException{
    -           mongoClient = new 
MongoClient(conf.get(MongoDBRdfConfiguration.MONGO_INSTANCE),
    -                           
Integer.valueOf(conf.get(MongoDBRdfConfiguration.MONGO_INSTANCE_PORT)));
    -           DB db = mongoClient.getDB( 
conf.get(MongoDBRdfConfiguration.MONGO_DB_NAME));
    +   private final MongoClient mongoClient;
    --- End diff --
    
    no need to add all the finals


> Temporal indexing support for MongoDB
> -------------------------------------
>
>                 Key: RYA-51
>                 URL: https://issues.apache.org/jira/browse/RYA-51
>             Project: Rya
>          Issue Type: New Feature
>          Components: dao
>            Reporter: Puja Valiyil 
>            Assignee: Puja Valiyil 
>
> There should be temporal indexing support for Mongo DB backed Rya.  i imagine 
> this would be implemented using another collection, similar to how temporal 
> indexing is implemented in Rya with a supplementary table.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to