[ 
https://issues.apache.org/jira/browse/RYA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427095#comment-15427095
 ] 

ASF GitHub Bot commented on RYA-133:
------------------------------------

Github user DLotts commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/72#discussion_r75383276
  
    --- Diff: 
extras/indexing/src/main/java/mvm/rya/indexing/FilterFunctionOptimizer.java ---
    @@ -101,23 +102,23 @@ public void setConf(final Configuration conf) {
             init = false;
             try {
                 init();
    -        } catch (final NumberFormatException | UnknownHostException e) {
    +        } catch (final NumberFormatException | IOException e) {
                 LOG.error("Unable to update to use new config, falling back to 
the old config.", e);
                 init = true;
             }
         }
     
    -    private synchronized void init() throws NumberFormatException, 
UnknownHostException {
    +    private synchronized void init() throws NumberFormatException, 
IOException {
             if (!init) {
                 if (ConfigUtils.getUseMongo(conf)) {
                     try {
                         final MongoClient mongoClient = 
MongoConnectorFactory.getMongoClient(conf);
    -                    geoIndexer = new MongoGeoIndexer(mongoClient);
    -                    geoIndexer.setConf(conf);
    -                    freeTextIndexer = new 
MongoFreeTextIndexer(mongoClient);
    -                    freeTextIndexer.setConf(conf);
    -                    temporalIndexer = new 
MongoTemporalIndexer(mongoClient);
    -                    temporalIndexer.setConf(conf);
    +                    geoIndexer = new MongoGeoIndexer();
    +                    ((AbstractMongoIndexer) geoIndexer).initIndexer(conf, 
mongoClient);
    --- End diff --
    
    GeoIndexer has null fields: storageStrategy , predicates.  The 
implementation init is not called?  In the code I see from develop, init does 
this 
    <code>predicates = ConfigUtils.getGeoPredicates(conf);  
    storageStrategy = ...<code>


> Mongo Secondary indexers are broken
> -----------------------------------
>
>                 Key: RYA-133
>                 URL: https://issues.apache.org/jira/browse/RYA-133
>             Project: Rya
>          Issue Type: Sub-task
>            Reporter: Andrew Smith
>            Assignee: Andrew Smith
>             Fix For: 3.2.10
>
>
> With the creation of integration tests for mongo support in the rya admin 
> shell, it was discovered that the refactoring of the mongo secondary indexers 
> broke some of the functionality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to