[
https://issues.apache.org/jira/browse/RYA-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435993#comment-15435993
]
ASF GitHub Bot commented on RYA-163:
------------------------------------
Github user amihalik commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/80#discussion_r76162747
--- Diff:
extras/rya.console/src/test/java/mvm/rya/shell/RyaAdminCommandsTest.java ---
@@ -123,6 +124,9 @@ public void deletePCJ() throws
InstanceDoesNotExistException, RyaClientException
@Test
public void getInstanceDetails() throws InstanceDoesNotExistException,
RyaClientException {
+ // This test is failed if the default timezone was not EST, so now
it's fixed at EST.
+ // If you get assert mismatch of EST!=EDT, try the deprecated
getTimeZone("EST") instead.
+ TimeZone.setDefault(TimeZone.getTimeZone("America/New_York"));
--- End diff --
I think there is a bigger issue... the setDetails() methods should be using
java 8 Time libraries. I haven't used those yet, but I'm guessing we want to
be using java.time.Instant instead java.util.Date
> PCJDetails Test Failures on non-EST TimeZones
> ---------------------------------------------
>
> Key: RYA-163
> URL: https://issues.apache.org/jira/browse/RYA-163
> Project: Rya
> Issue Type: Bug
> Environment: Apache Jenkins machine (UTC Timezone)
> Reporter: Aaron Mihalik
> Assignee: David W. Lotts
> Priority: Blocker
>
> There are two tests failing on the build. I think they are both due to a
> timezone issue.
> I was able to reproduce these failures by setting my local timezone to
> something other than eastern.
> https://builds.apache.org/job/incubator-rya-develop/27/testReport/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
