[ 
https://issues.apache.org/jira/browse/RYA-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15468344#comment-15468344
 ] 

ASF GitHub Bot commented on RYA-169:
------------------------------------

GitHub user DLotts opened a pull request:

    https://github.com/apache/incubator-rya/pull/87

    RYA-169 MongoRya DAO/Examples fixed

    ### Description
    >What Changed?
    
    Removed a redundant method and call in RyaSailFactory to get/create a Mongo 
client/connection.  Mongo should only have one client per JVM.  So the 
MongoConnectorFactory is used.
    Credentials are now optional for MongoDB.
    
    ### Tests
    >Coverage?
    
    MongoRyaDirectExample.java runs without error.
    
    ### Links
    [Jira RYA-169](https://issues.apache.org/jira/browse/RYA-169)
    
    ### Checklist
    - [ ] Code Review
    - [x] Squash Commits
    
    #### People To Reivew
    isper3at


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DLotts/incubator-rya RYA-169_MongoExamples

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rya/pull/87.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #87
    
----
commit 00d2cb8085ed1b7a17a758365486f64845a8b268
Author: isper3at <smith...@gmail.com>
Date:   2016-09-06T18:03:49Z

    RYA-169_MongoExamples
    Removed updateMongoConfig() from RyaSailFactory, used MongoConnectorFactory.
    Credentials are now optional for MongoDB.
    Removed null checks for credentials.

----


> MongoRya DAO/Examples are currently broken
> ------------------------------------------
>
>                 Key: RYA-169
>                 URL: https://issues.apache.org/jira/browse/RYA-169
>             Project: Rya
>          Issue Type: Bug
>          Components: clients, dao, examples
>            Reporter: Puja Valiyil 
>            Assignee: David W. Lotts
>            Priority: Blocker
>
> With the pull in of RYA-81 or RYA-82, the examples became broken for Mongo.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to