[
https://issues.apache.org/jira/browse/RYA-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478266#comment-15478266
]
ASF GitHub Bot commented on RYA-172:
------------------------------------
GitHub user ejwhite922 opened a pull request:
https://github.com/apache/incubator-rya/pull/89
RYA-172 Fixed CopyTool unit test from not clearing tmp hadoop directo…
…ry between tests.
## Description
Fixed CopyTool unit test so it clears out the hadoop temp directory it uses
between each test. Most of the changes are from save actions. Search for the
importFilesToChildTable method to see actual changes.
### Tests
Ran unit tests multiple times
### Links
[Jira](https://issues.apache.org/jira/browse/RYA-172)
### Checklist
- [x] Code Review
- [ ] Squash Commits
#### People To Review
@amihalik
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ejwhite922/incubator-rya
RYA-172_RyaMergerTestTempData
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rya/pull/89.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #89
----
commit 2e3505eb6993c2df09470b782418b0b8275cc762
Author: ejwhite922 <eric.wh...@sparta.com>
Date: 2016-09-09T20:34:32Z
RYA-172 Fixed CopyTool unit test from not clearing tmp hadoop directory
between tests.
----
> Rya Merger Test Fail (persists temp data between test)
> ------------------------------------------------------
>
> Key: RYA-172
> URL: https://issues.apache.org/jira/browse/RYA-172
> Project: Rya
> Issue Type: Bug
> Reporter: Aaron Mihalik
> Assignee: Eric White
>
> CopyToolTest.testImportDirectoryTool will fail the second time it's run.
> There is data hanging around in /tmp/hadoop-amihalik/ (for me) after the
> first run of the test and it's causing issues the second time.
> To reproduce:
> in incubator-rya, build rya:
> {code}
> mvn clean install -DskipTests
> {code}
> now run the rya.merger tests a couple times:
> {code}
> cd extras/rya.merger
> mvn clean install
> mvn clean install
> {code}
> The error should be this on the second time through
> {code}
> CopyToolTest.testImportDirectoryTool:355 expected:<20> but was:<0>
> {code}
> This was in my log (in eclispe):
> {code}
> 2016-09-07 18:16:44,752 ERROR [main] merge.CopyTool
> (CopyTool.java:setupAndRun(860)) - Error running copy tool
> java.io.IOException: Target
> /tmp/hadoop-mihalik/copy_tool_import/ct_spo/ct_spo is a directory
> {code}
> my work around is to
> {code}
> rm -rf /tmp/hadoop-mihalik/
> {code}
> between tests
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
