[
https://issues.apache.org/jira/browse/RYA-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15553419#comment-15553419
]
ASF GitHub Bot commented on RYA-177:
------------------------------------
GitHub user DLotts opened a pull request:
https://github.com/apache/incubator-rya/pull/99
rya-177 WIP; indexing and mapreduce are now optional profiles in Mave…
## Description
>What Changed?
Made indexing and mapreduce modules part of profiles that are not built
unless using one of these:
mvn ... -P indexing
mvn ... -P mapreduce
The purpose is to make geotools related features optional since it has an
LGPL license.
Also under RYA-177 are removing several other less difficult dependencies.
TODO: remove Geo dependencies from top level POM.xml and find dependencies.
They are marked with comments. Also remove other dependencies that have
incompatible licenses.
### Tests
>Coverage?
No additional junit tests are needed. A good test is to run exactly this
in the project root:
mvn license:aggregate-add-third-party
GeoTools should be missing. Also look for GPL and LGPL and some other
incompatible licensed libraries. look on the rya dev list where I posted the
subset of bad ones. It subject has the wrong issue number, here it is:
subject: RYA-179 Review License / Copyright notices on Rya Artifacts
found here:
https://www.mail-archive.com/dev@rya.incubator.apache.org/msg00969.html
### Links
[Jira](https://issues.apache.org/jira/browse/RYA-177)
### Checklist
- [ ] Code Review
- [ ] Squash Commits
#### People To Reivew
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DLotts/incubator-rya
RYA-177_incompatLicenseOptional
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rya/pull/99.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #99
----
commit 714be87f230ea1da596870910206085b3e3e410d
Author: David W. Lotts <david.lo...@parsons.com>
Date: 2016-10-06T21:54:40Z
rya-177 WIP; indexing and mapreduce are now optional profiles in Maven.
TODO: remove Geo from top level POM and find dependencies.
----
> Review License on Rya Dependencies
> ----------------------------------
>
> Key: RYA-177
> URL: https://issues.apache.org/jira/browse/RYA-177
> Project: Rya
> Issue Type: Task
> Affects Versions: 3.2.10
> Reporter: Aaron Mihalik
> Assignee: David W. Lotts
> Priority: Blocker
>
> * jgridshift:jgridshift appears to be LGPL licensed
> (https://github.com/floscher/jGridShift/blob/master/LICENSE). You may
> not use this software. It looks like it was not appropriately marked in
> its pom which is why the configuration from Rya's parent apache.pom did
> not catch it. This is brought in via org.geotools.xsd:gt-xsd-gml3.
> * colt (http://dst.lbl.gov/ACSSoftware/colt/) appears to be another
> brought in by com.tinkerpop.blueprints:blueprints-core
> * com.google.code.findbugs:jsr305 is another example of GPL licensing.
> While the artifact appears to have the ASL tagged on the pom, all
> Findbugs documentation states that the project is GPL.
> I would recommend to make a pass over your dependencies to verify that
> you aren't depending on any projects which are licensed with a license
> on this list: http://www.apache.org/legal/resolved.html#category-x. See
> http://www.apache.org/licenses/GPL-compatibility.html for more details.
> The above three examples were found via a brief glance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
