Github user meiercaleb commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/174#discussion_r126755510
--- Diff:
sail/src/main/java/org/apache/rya/rdftriplestore/RdfCloudTripleStoreConnection.java
---
@@ -345,6 +346,7 @@ protected void commitInternal() throws SailException {
&& this.inferenceEngine != null
) {
try {
--- End diff --
I think we talked about this briefly, but don't most inference visitors key
in on the pattern ?x a <uri:class1>? After a given visitor expands the query,
isn't this pattern gone? How can another inference rule be applied without
this pattern? Does the new logic get unioned with the old pattern? Are our
rules disjoint enough that this is a non-issue? If they do overlap, how do we
determine a priority? I understand that currently the order is hard coded, so
there is really nothing to do at this point. But I think that some thought
should be put into this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
