[
https://issues.apache.org/jira/browse/RYA-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158881#comment-16158881
]
ASF GitHub Bot commented on RYA-361:
------------------------------------
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/224#discussion_r137833944
--- Diff:
extras/rya.export/export.client/src/main/java/org/apache/rya/export/client/conf/MergeConfigurationCLI.java
---
@@ -149,7 +145,12 @@ public static MergeToolConfiguration
createConfigurationFromFile(final File conf
throw new MergeConfigurationException("Failed to create a
config based on the provided configuration.", JAXBe);
}
}
-
+ /**
+ * returns the time option and makes it required.
+ * This is for API and is not used internally as of v3.2.11
+ * @return
--- End diff --
Add description to return and throws. Make it clear that it returns a time
or throws an exception when no time is configured because time is required.
> JCalendar library has an incompatible license
> ---------------------------------------------
>
> Key: RYA-361
> URL: https://issues.apache.org/jira/browse/RYA-361
> Project: Rya
> Issue Type: Improvement
> Components: clients, export
> Reporter: David W. Lotts
> Assignee: David W. Lotts
> Priority: Blocker
> Labels: export, license
> Fix For: 3.2.11
>
>
> rya.export depends on JCalendar which is LGPL [1] (brought in by RYA-123)
> Its usage should be replaced and removed from the pom.xml(s).
> This is blocking the release of 3.2.11
> [1]https://toedter.com/jcalendar/
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
