Github user meiercaleb commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/248#discussion_r148107974 --- Diff: extras/periodic.notification/api/src/main/java/org/apache/rya/periodic/notification/api/PeriodicNotificationClient.java --- @@ -36,29 +36,26 @@ * Adds a new notification to be registered with the {@link NotificationCoordinatorExecutor} * @param notification - notification to be added */ - public void addNotification(PeriodicNotification notification); --- End diff -- Not thrilled about removing public from the interface method headers. I understand that it is redundant, but I think that most style guides suggest that you include the public declaration. Also, I think that pretty much all interfaces within Rya explicitly declare their methods as public.
---