Github user kchilton2 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/251#discussion_r153260742
--- Diff:
extras/rya.pcj.fluo/pcj.fluo.app/src/main/java/org/apache/rya/indexing/pcj/fluo/app/BindingSetRow.java
---
@@ -77,4 +78,31 @@ public static BindingSetRow make(final Bytes row) {
final String bindingSetString = rowArray.length == 2 ? rowArray[1]
: "";
return new BindingSetRow(nodeId, bindingSetString);
}
+
+ public static BindingSetRow makeFromShardedRow(Bytes prefixBytes,
Bytes row) {
+ return make(BindingHashShardingFunction.removeHash(prefixBytes,
row));
+ }
+
+ @Override
+ public String toString() {
--- End diff --
This method looks a little weird. You don't really need to use a
StringBuilder since you're not using loops or anything to build your final
string. It's good for avoiding building a bunch of little strings that get
composed into a larger string late because Strings are immutable and the
builder is not. However, the compiler can figure out simple stuff where there
is no looping, so you don't need to use one here.
---
