Github user kchilton2 commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/252#discussion_r155076044
  
    --- Diff: extras/rya.geoindexing/pom.xml ---
    @@ -1,206 +1,51 @@
     <?xml version='1.0'?>
    -
    -<!-- Licensed to the Apache Software Foundation (ASF) under one or more 
contributor 
    -    license agreements. See the NOTICE file distributed with this work for 
additional 
    -    information regarding copyright ownership. The ASF licenses this file 
to 
    -    you under the Apache License, Version 2.0 (the "License"); you may not 
use 
    -    this file except in compliance with the License. You may obtain a copy 
of 
    -    the License at http://www.apache.org/licenses/LICENSE-2.0 Unless 
required 
    -    by applicable law or agreed to in writing, software distributed under 
the 
    -    License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR 
CONDITIONS 
    -    OF ANY KIND, either express or implied. See the License for the 
specific 
    -    language governing permissions and limitations under the License. -->
    -
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +
    +  http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing,
    +software distributed under the License is distributed on an
    +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +KIND, either express or implied.  See the License for the
    +specific language governing permissions and limitations
    +under the License.
    +-->
     <project xmlns="http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
    -  <modelVersion>4.0.0</modelVersion>
    -  <parent>
    -    <groupId>org.apache.rya</groupId>
    -    <artifactId>rya.extras</artifactId>
    -    <version>3.2.12-incubating-SNAPSHOT</version>
    -  </parent>
    -  <artifactId>rya.geoindexing</artifactId>
    -  <packaging>pom</packaging>
    -  <name>Apache Rya Geo Indexing Projects</name>
    -  <description>This parent has several alternative implementations using 
different libraries or versions of the same library.  
    -  Specifically 
    -          Geomesa depends on geotools v5.1 and 
    -          GeoWave depends on geotools v6.
    -  See the module poms for the actual versions.
    -  </description>
    +    <modelVersion>4.0.0</modelVersion>
    +
    +    <parent>
    +        <groupId>org.apache.rya</groupId>
    +        <artifactId>rya.extras</artifactId>
    +        <version>3.2.12-incubating-SNAPSHOT</version>
    +    </parent>
    +
    +    <artifactId>rya.geoindexing</artifactId>
    +    <packaging>pom</packaging>
    +
    +    <name>Apache Rya Geo Indexing Projects</name>
    +    <description>
    +        This parent has several alternative implementations using 
different libraries or versions of the same library.  
    +        Specifically 
    +            Geomesa depends on geotools v5.1 and 
    +            GeoWave depends on geotools v6.
    +        See the module poms for the actual versions.
    +     </description>
    +
          <modules>
             <!-- common for all implementations  -->
    -            <!-- geomesa for accumulo, uses geotools (not compatible with 
geowave's dependencies)   -->
    -            <!-- geo wave for accumulo, uses geotools (not compatible with 
geomesa's dependencies)  -->
    -            <!-- mongo native geo, not accumulo  -->
    -           <module>geo.common</module>
    -           <module>geo.geomesa</module>
    -           <module>geo.geowave</module>
    -           <module>geo.mongo</module>
    -     </modules>
    -    <properties>
    -        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    -    </properties>
    -
    -   <dependencies>
    -           <dependency>
    -                   <groupId>com.vividsolutions</groupId>
    -                   <artifactId>jts</artifactId>
    -                   <version>1.13</version>
    -           </dependency>
    -           <dependency>
    -              <groupId>org.apache.accumulo</groupId>
    -            <artifactId>accumulo-minicluster</artifactId>
    -            <scope>test</scope>
    -        </dependency>
    -
    -        <dependency>
    -            <groupId>org.apache.rya</groupId>
    -            <artifactId>rya.sail</artifactId>
    -            <exclusions>
    -                <exclusion>
    -                    <artifactId>hsqldb</artifactId>
    -                    <groupId>hsqldb</groupId>
    -                </exclusion>
    -            </exclusions>
    -        </dependency>
    -        <dependency>
    -            <groupId>org.apache.rya</groupId>
    -            <artifactId>rya.indexing</artifactId>
    -        </dependency>
    -        <dependency>
    -            <groupId>org.apache.rya</groupId>
    -            <artifactId>accumulo.rya</artifactId>
    -        </dependency>
    -        <dependency>
    -            <groupId>org.apache.rya</groupId>
    -            <artifactId>mongodb.rya</artifactId>
    -        </dependency>
    -        <dependency>
    -            <groupId>org.apache.rya</groupId>
    -            <artifactId>rya.prospector</artifactId>
    -        </dependency>
    -
    -        <!-- Free Text Indexing -->
    -        <dependency>
    -            <groupId>org.apache.lucene</groupId>
    -            <artifactId>lucene-core</artifactId>
    -        </dependency>
    -        <dependency>
    -            <groupId>org.apache.lucene</groupId>
    -            <artifactId>lucene-analyzers</artifactId>
    -        </dependency>
    -
    -        <dependency>
    -            <groupId>commons-codec</groupId>
    -            <artifactId>commons-codec</artifactId>
    -        </dependency>
    -
    -           <dependency>
    -                   <groupId>junit</groupId>
    -                   <artifactId>junit</artifactId>
    -                   <scope>test</scope>
    -           </dependency>
    -           <dependency>
    -                   <groupId>org.mockito</groupId>
    -                   <artifactId>mockito-all</artifactId>
    -                   <scope>test</scope>
    -           </dependency>
    -        <dependency>
    -            <groupId>org.apache.rya</groupId>
    -            <artifactId>accumulo.rya</artifactId>
    -            <type>test-jar</type>
    -            <scope>test</scope>
    -        </dependency>
    -        <dependency>
    -            <groupId>org.apache.rya</groupId>
    -            <artifactId>mongodb.rya</artifactId>
    -            <type>test-jar</type>
    -            <scope>test</scope>
    -        </dependency>
    -    </dependencies>
    -   <build>
    -           <pluginManagement>
    -                   <plugins>
    -                           <plugin>
    -                                   <groupId>org.apache.rat</groupId>
    -                                   
<artifactId>apache-rat-plugin</artifactId>
    -                                   <configuration>
    -                                           <excludes>
    -                                                   <!-- RDF data Files -->
    -                                                   
<exclude>**/*.ttl</exclude>
    -
    -                                                   <!-- Services Files -->
    -                                                   
<exclude>**/resources/META-INF/services/**</exclude>
    --- End diff --
    
    They seem to be unnecessary. I ran a build with rat enabled and no files 
failed the rat test.


---

Reply via email to