[ 
https://issues.apache.org/jira/browse/RYA-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318700#comment-16318700
 ] 

ASF GitHub Bot commented on RYA-303:
------------------------------------

Github user ejwhite922 commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/172#discussion_r160452112
  
    --- Diff: 
common/rya.api/src/main/java/org/apache/rya/api/instance/RyaDetailsToConfiguration.java
 ---
    @@ -51,17 +51,29 @@ public static void addRyaDetailsToConfiguration(final 
RyaDetails details, final
     
             checkAndSet(conf, ConfigurationFields.USE_ENTITY, 
details.getEntityCentricIndexDetails().isEnabled());
             checkAndSet(conf, ConfigurationFields.USE_FREETEXT, 
details.getFreeTextIndexDetails().isEnabled());
    -      //RYA-215        checkAndSet(conf, ConfigurationFields.USE_GEO, 
details.getGeoIndexDetails().isEnabled());
    +        //RYA-215        checkAndSet(conf, ConfigurationFields.USE_GEO, 
details.getGeoIndexDetails().isEnabled());
             checkAndSet(conf, ConfigurationFields.USE_TEMPORAL, 
details.getTemporalIndexDetails().isEnabled());
             final PCJIndexDetails pcjDetails = details.getPCJIndexDetails();
    -        if (pcjDetails.isEnabled() && 
pcjDetails.getFluoDetails().isPresent()) {
    -            checkAndSet(conf, ConfigurationFields.USE_PCJ_UPDATER, true);
    -            conf.set(ConfigurationFields.FLUO_APP_NAME, 
pcjDetails.getFluoDetails().get().getUpdateAppName());
    -            conf.set(ConfigurationFields.PCJ_UPDATER_TYPE, "FLUO");
    -            conf.set(ConfigurationFields.PCJ_STORAGE_TYPE, "ACCUMULO");
    +        
    +        if(conf.getBoolean(ConfigurationFields.USE_MONGO, false) ) {
    +           if(pcjDetails.isEnabled()) {
    +                   conf.set(ConfigurationFields.PCJ_STORAGE_TYPE, "MONGO");
    --- End diff --
    
    Can "MONGO" be replaced with PrecomputedJoinStorageType.MONGO.toString()?  
Or is the dependency for that class not in rya.api?


> Mongo PCJ indexer support
> -------------------------
>
>                 Key: RYA-303
>                 URL: https://issues.apache.org/jira/browse/RYA-303
>             Project: Rya
>          Issue Type: Improvement
>            Reporter: Andrew Smith
>            Assignee: Andrew Smith
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to