Github user kchilton2 commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/172#discussion_r160510946
  
    --- Diff: 
dao/mongodb.rya/src/main/java/org/apache/rya/mongodb/instance/MongoDetailsAdapter.java
 ---
    @@ -124,11 +123,6 @@ private static DBObject toDBObject(final 
PCJIndexDetails pcjIndexDetails) {
             // Is Enabled
             builder.add(PCJ_ENABLED_KEY, pcjIndexDetails.isEnabled());
     
    -        // Fluo Details if present.
    -        if(pcjIndexDetails.getFluoDetails().isPresent()) {
    --- End diff --
    
    I don't think we should be deleting conversion code just because we do not 
support this piece of information in Mongo DB currently. The class advertises 
itself as a converter from RyaDetails object to BasicDBObject. Either the 
RyaDetails used by Mongo should be different from that used by Accumulo (I 
don't think this is the route we should go), or some other hunk of code should 
ensure the fluo details are never present before it even gets to this point.
      


---

Reply via email to