Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/272#discussion_r167231162
--- Diff:
extras/rya.streams/api/src/main/java/org/apache/rya/streams/api/queries/InMemoryQueryRepository.java
---
@@ -243,8 +274,68 @@ private void updateCache() {
it.close();
}
} catch (final QueryChangeLogException e) {
- LOG.error("Could not close the " +
CloseableIteration.class.getName(), e);
+ log.error("Could not close the " +
CloseableIteration.class.getName(), e);
}
+
+ log.trace("updateCache() - Exit");
+ }
+ }
+
+ @Override
+ protected void runOneIteration() throws Exception {
+ log.trace("runOneIteration() - Enter");
+ lock.lock();
+ try {
+ updateCache();
+ } finally {
+ lock.unlock();
+ }
+ log.trace("runOneIteration() - Exit");
--- End diff --
Should this log message be moved up into the finally block so it's called
if an Exception is thrown?
---
