[ 
https://issues.apache.org/jira/browse/RYA-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358519#comment-16358519
 ] 

ASF GitHub Bot commented on RYA-443:
------------------------------------

Github user ejwhite922 commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/272#discussion_r167231162
  
    --- Diff: 
extras/rya.streams/api/src/main/java/org/apache/rya/streams/api/queries/InMemoryQueryRepository.java
 ---
    @@ -243,8 +274,68 @@ private void updateCache() {
                         it.close();
                     }
                 } catch (final QueryChangeLogException e) {
    -                LOG.error("Could not close the " + 
CloseableIteration.class.getName(), e);
    +                log.error("Could not close the " + 
CloseableIteration.class.getName(), e);
                 }
    +
    +            log.trace("updateCache() - Exit");
    +        }
    +    }
    +
    +    @Override
    +    protected void runOneIteration() throws Exception {
    +        log.trace("runOneIteration() - Enter");
    +        lock.lock();
    +        try {
    +            updateCache();
    +        } finally {
    +            lock.unlock();
    +        }
    +        log.trace("runOneIteration() - Exit");
    --- End diff --
    
    Should this log message be moved up into the finally block so it's called 
if an Exception is thrown?


> Implement a single node query manager
> -------------------------------------
>
>                 Key: RYA-443
>                 URL: https://issues.apache.org/jira/browse/RYA-443
>             Project: Rya
>          Issue Type: Task
>            Reporter: Andrew Smith
>            Assignee: Kevin Chilton
>            Priority: Major
>
> We need an application that watches the QueryChangeLog to see when the 
> isActive state of queries changes and then reacts to the state change. If 
> isActive goes to true, the system must start processing the query. If it is 
> false, then it must stop processing the query. This application needs to 
> start when the host machine starts. We plan to support CentOS 7.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to