[ https://issues.apache.org/jira/browse/RYA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16444469#comment-16444469 ]
ASF GitHub Bot commented on RYA-405: ------------------------------------ Github user kchilton2 commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/291#discussion_r182596437 --- Diff: common/rya.api/src/main/java/org/apache/rya/api/domain/VarNameUtils.java --- @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.rya.api.domain; + +import org.apache.commons.lang.StringUtils; +import org.eclipse.rdf4j.model.Value; +import org.eclipse.rdf4j.model.ValueFactory; +import org.eclipse.rdf4j.model.impl.SimpleValueFactory; +import org.eclipse.rdf4j.query.algebra.Var; +import org.eclipse.rdf4j.query.algebra.helpers.TupleExprs; + +/** + * Utility methods and constants for RDF {@link Var} names. + */ +public final class VarNameUtils { --- End diff -- Us needing this class at all is kind of a smell. Maybe note that this is discouraged if there's any other way to figure out if your Var is constant or anonymous. I think there are methods that tell you that information. > Migrate from Sesame to rdf4j libs > ---------------------------------- > > Key: RYA-405 > URL: https://issues.apache.org/jira/browse/RYA-405 > Project: Rya > Issue Type: Improvement > Affects Versions: 3.2.12 > Reporter: Jorge Machado > Assignee: Eric White > Priority: Major > Fix For: 4.0.0 > > > I have migrated all the project to the newer libs from rdf4j instead of using > the old ones. > Can someone take a look ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)