AlexStocks commented on code in PR #666: URL: https://github.com/apache/incubator-seata-go/pull/666#discussion_r1505383418
########## pkg/discovery/config_config.go: ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package discovery + +import ( + "flag" +) + +// Configuration center for (micro) services. +// Config for configuration center self. Using this config, we can connect to configuration center. In most cases, configuration +// center is using the registry type's configuration, such as nacos configuration center, kubernetes configmap, etc. +// For example, with registry type being `nacos`, seata server's configuration is usaually saved in nacos configuration `data-id=seataServer.Properties`. +// Client could push custom configs using go-SDK provided by configuration center (as mentioned above, in most cases, it's the registry center), +// so services registered within registry center can make use of these custom configs. +type ConfigConfig struct { Review Comment: ConfigConfig 这种名字有点别扭，取名 ConfigCenterConfig 更合适点吧？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
