funky-eyes commented on code in PR #6569: URL: https://github.com/apache/incubator-seata/pull/6569#discussion_r1629042530
########## rm-datasource/src/main/java/org/apache/seata/rm/datasource/undo/AbstractUndoLogManager.java: ########## @@ -339,20 +339,22 @@ public void undo(DataSourceProxy dataSourceProxy, String xid, long branchId) thr State.GlobalFinished.name()); } } else { - insertUndoLogWithGlobalFinished(xid, branchId, UndoLogParserFactory.getInstance(), conn); - conn.commit(); - if (LOGGER.isInfoEnabled()) { - LOGGER.info("xid {} branch {}, undo_log added with {}", xid, branchId, - State.GlobalFinished.name()); + try { + insertUndoLogWithGlobalFinished(xid, branchId, UndoLogParserFactory.getInstance(), conn); Review Comment: Why is it modified here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org For additional commands, e-mail: notifications-h...@seata.apache.org