funky-eyes commented on code in PR #6806:
URL: https://github.com/apache/incubator-seata/pull/6806#discussion_r1741353565


##########
rm-datasource/src/main/java/org/apache/seata/rm/datasource/sql/struct/TableMetaCacheFactory.java:
##########
@@ -135,6 +135,7 @@ static class TableMetaRefreshHolder {
                         }
                     } catch (Exception exx) {
                         LOGGER.error("table refresh error:{}", 
exx.getMessage(), exx);
+                        lastRefreshFinishTime = System.nanoTime();

Review Comment:
   增加一行注释说明下为什么这么改动,以便于用户看到这段代码时,能知道为什么这么做的场景。然后再登记下pr,属于优化类型。
   Add a comment explaining why this change was made, so users understand the 
context when they see this code. Then, log this PR, noting that it is for 
optimization.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org

Reply via email to