Copilot commented on code in PR #7222:
URL: https://github.com/apache/incubator-seata/pull/7222#discussion_r1997576606
##########
server/src/main/java/org/apache/seata/server/cluster/raft/serializer/CustomDeserializer.java:
##########
@@ -29,7 +31,13 @@ public class CustomDeserializer extends
JsonDeserializer<Class<?>> {
String currentPackage = "org.apache.seata.server";
- String permitPackage = "org.apache.seata";
+ private static final List<String> PERMIT_PACKAGES = new ArrayList<>();
+
+ static {
+ PERMIT_PACKAGES.add("org.apache.seata");
+ // The storage structure of vgroup is a map.
+ PERMIT_PACKAGES.add("java.util.HashMap");
Review Comment:
Review the security implications of adding 'java.util.HashMap' to the
permitted packages list to ensure it does not widen the deserialization attack
surface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
