luky116 commented on code in PR #828:
URL:
https://github.com/apache/incubator-seata-go/pull/828#discussion_r2133818520
##########
pkg/datasource/sql/undo/base/undo.go:
##########
@@ -354,6 +354,10 @@ func (m *BaseUndoLogManager) Undo(ctx context.Context,
dbType types.DBType, xid
if err = undoExecutor.ExecuteOn(ctx, dbType, conn); err
!= nil {
log.Errorf("execute on fail, err: %v", err)
+ if undoErr, ok := err.(*serr.SeataError); ok &&
undoErr.Code == serr.SQLUndoDirtyError {
+ return
serr.New(serr.TransactionErrorCodeBranchRollbackFailedUnretriable, fmt.Sprintf(
Review Comment:
这个长串用日志输出，返回一个简单描述的 error 就可以
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
