flypiggyyoyoyo commented on code in PR #838:
URL:
https://github.com/apache/incubator-seata-go/pull/838#discussion_r2144573835
##########
pkg/saga/statemachine/engine/core/process_ctrl_statemachine_engine.go:
##########
@@ -32,7 +35,7 @@ import (
)
type ProcessCtrlStateMachineEngine struct {
Review Comment:
This would lead to circular dependencies. The coupling between them is so
deep that it even extends to the method and struct levels, and there are no
interfaces, making it quite challenging to decouple. Considering that the role
of `process_ctrl_statemachine_engine.go` is to implement the core logic of the
state machine engine, my suggestion is to retain the `core` package and move
`process_ctrl_statemachine_engine.go` into it. The remaining contents of the
`core` package should be extracted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
