Copilot commented on code in PR #7432:
URL: https://github.com/apache/incubator-seata/pull/7432#discussion_r2144652031
##########
pom.xml:
##########
@@ -411,6 +450,22 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>include-test-modules</id>
+ <activation>
+ <file>
+ <exists>test/pom.xml</exists>
+ </file>
+ <property>
+ <name>!excludeTestModules</name>
Review Comment:
[nitpick] Using a negated property name in activation may be confusing;
consider using a positive property condition (e.g.,
<excludeTestModules>false</excludeTestModules>) for clarity or document this
negation behavior.
```suggestion
<name>includeTestModules</name>
```
##########
pom.xml:
##########
@@ -411,6 +450,22 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>include-test-modules</id>
+ <activation>
+ <file>
+ <exists>test/pom.xml</exists>
+ </file>
+ <property>
+ <name>!excludeTestModules</name>
Review Comment:
Activation based solely on the existence of test/pom.xml may not cover other
test modules like test-old-version if their POM paths differ; consider using a
property-based activation or extending the path check.
```suggestion
<property>
<name>includeTestModules</name>
<value>true</value>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
