maple525866 opened a new pull request, #7504:
URL: https://github.com/apache/incubator-seata/pull/7504
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!-- Please make sure you have read and understood the contributing
guidelines -->
- [ ] I have registered the PR [changes](../changes).
### Ⅰ. Describe what this PR did
Since Druid has `setDriverClassLoader(getDriverClassLoader())`, and
`HikariConfig` has no corresponding API, Druid can set the driver class loader
normally, but Hikari cannot set the class loader directly.
Here is my solution:
By calling the method of the abstract parent class, get the driver class
loader, explicitly load and register the driver to DriverManager, and finally
configure HikariConfig to solve this problem.
And use two test methods to test different MySQL driver situations to verify
whether they can be loaded correctly.
### Ⅱ. Does this pull request fix one issue?
fixes #7499
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
mvn clean test
Add two test methods based on the original `AbstractDataSourceProviderTest`
test class to test whether different MySQL version drivers are loaded correctly
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
