Re: [PR] Bugfix: Failure to Enter TimeoutRollbackRetrying State [incubator-seata]

Sun, 06 Jul 2025 07:54:35 -0700 


simzyoo commented on code in PR #7480:
URL: https://github.com/apache/incubator-seata/pull/7480#discussion_r2188372593


##########
server/src/main/java/org/apache/seata/server/coordinator/DefaultCore.java:
##########
@@ -486,7 +486,7 @@ public boolean doGlobalRollback(GlobalSession 
globalSession, boolean retrying) t
                                         String.valueOf(retrying),
                                         ex.getMessage()
                                     });
-                            if (!retrying) {
+                            if (shouldQueueToRetryRollback(retrying, 
globalSession)) {

Review Comment:
   > > > > > Why not directly remove this retrying check? Then handle the 
transaction state transition in the queueToRetryRollback method instead?
   > > > > 
   > > > > 
   > > > > Does it mean moving the logic of 
shouldQueueToRetryRollback(retrying, globalSession) into 
globalSession.queueToRetryRollback()?
   > > > 
   > > > 
   > > > Yes, because regardless of whether it is in a retry state or not, the 
transaction always transitions from state A to a substate of A, such as 
Committing. If the transaction in this state fails, the state will change to 
CommitRetry.
   > > 
   > > 
   > > Ok,is it like this?
   > > <img alt="image" width="646" 
src="https://private-user-images.githubusercontent.com/209348861/461322620-ad2199ec-2a24-4c12-9712-8885fcccf12e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTE2MTYzNjEsIm5iZiI6MTc1MTYxNjA2MSwicGF0aCI6Ii8yMDkzNDg4NjEvNDYxMzIyNjIwLWFkMjE5OWVjLTJhMjQtNGMxMi05NzEyLTg4ODVmY2NjZjEyZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwNzA0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDcwNFQwODAxMDFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wYzA5NTViY2I1MzIyMDdjMjc2ZDkyODcwZWVmMTFiZWZiMjYxNzMxZTdhN2UyOTlhYTU4ZjdlY2Q4ZmZkZWEzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.znIHFHqmxWrZfkC1Ml0FaA0A1Im-oyIailgzF8inG5M";>
   > 
   > yes
   
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to