Code-Fight commented on code in PR #857:
URL:
https://github.com/apache/incubator-seata-go/pull/857#discussion_r2217273036
##########
pkg/datasource/sql/datasource/base/meta_cache_test.go:
##########
@@ -229,11 +233,11 @@ func TestBaseTableMetaCache_GetTableMeta(t *testing.T) {
cache := &BaseTableMetaCache{
trigger: mockTrigger,
cache: map[string]*entry{
- "T_USER": {
+ "t_user2": {
Review Comment:
We also need some tests with lowercase only.
##########
pkg/datasource/sql/util/lockkey.go:
##########
@@ -34,7 +34,7 @@ func BuildLockKey(records *types.RecordImage, meta
types.TableMeta) string {
colIndex int
}
- lockKeys.WriteString(meta.TableName)
+ lockKeys.WriteString(meta.UpperTableName)
Review Comment:
I think, do we really need a separate UpperTableName field? Would it be
sufficient to just convert the table name to uppercase during the construction
of the lock key and then use it directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
