funky-eyes commented on PR #7492: URL: https://github.com/apache/incubator-seata/pull/7492#issuecomment-3134565304
> There are two options: > > The first is to make the test methods in `HttpClient5UtilTest` work in an JDK 11+ environment first, and then handle it together as mentioned in the issue below. > > * [Add Dependency Detection and Fallback Logic for HttpClient5 #7561](https://github.com/apache/incubator-seata/issues/7561) > > The second is to address it in the current PR. > > Which approach do you think is better? I don't think this approach is appropriate, because if JDK 8 does not support HTTP/2, then upgrading to HttpClient 5 does not make much sense. Therefore, I suggest looking into OkHttp to see if it supports HTTP/2 on JDK 8. If it does, we can consider switching to OkHttp instead of HttpClient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
