funky-eyes commented on code in PR #7580:
URL: https://github.com/apache/incubator-seata/pull/7580#discussion_r2265794080
##########
server/src/test/java/org/apache/seata/server/DynamicPortTestConfig.java:
##########
Review Comment:
> Do we need to apply `@TestPropertySource(properties =
{"server.port=${random.int[10000,20000]}"})` to all places where
`DynamicPortTestConfig` is used?
If DynamicPortTestConfig can be made effective, I don’t think this approach
is necessary. My current change is only temporary, intended to prevent CI
failures from blocking code review. Therefore, so I do not plan to replace
`DynamicPortTestConfig` with `@TestPropertySource(properties =
{"server.port=${random.int[10000,20000}"})`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@seata.apache.org
For additional commands, e-mail: notifications-h...@seata.apache.org
