funky-eyes commented on code in PR #7559:
URL: https://github.com/apache/incubator-seata/pull/7559#discussion_r2281430044
##########
rm-datasource/src/main/java/org/apache/seata/rm/datasource/DataSourceProxy.java:
##########
@@ -47,7 +47,7 @@
* The type Data source proxy.
*
*/
-public class DataSourceProxy extends AbstractDataSourceProxy implements
Resource {
+public class DataSourceProxy extends AbstractDataSourceProxy implements
Resource, AutoCloseable {
Review Comment:
> How about implementing `AutoCloseable` so that it can be automatically
closed using a try-with-resources statement?
>
> WDYT?
I don’t think it’s necessary, because the datasource itself already provides
a close interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
