funky-eyes commented on code in PR #7559:
URL: https://github.com/apache/incubator-seata/pull/7559#discussion_r2297610736
##########
rm-datasource/src/main/java/org/apache/seata/rm/datasource/DataSourceProxy.java:
##########
@@ -452,4 +452,9 @@ private void validMySQLVersion(Connection connection) {
LOGGER.error("check mysql version fail error: {}", e.getMessage());
}
}
+
+ public void close() throws Exception {
+ DefaultResourceManager.get().unregisterResource(this);
Review Comment:
> That’s correct. But wasn’t the implementation for that part planned to be
done in a separate PR?
So I think this line of code should be added in a separate PR, not in this
one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
