funky-eyes commented on code in PR #7604:
URL: https://github.com/apache/incubator-seata/pull/7604#discussion_r2305813179
##########
config/seata-config-nacos/src/test/java/io/seata/config/extend/TestConfigFromExtendSPI.java:
##########
@@ -56,33 +57,52 @@ public static void setup() throws NacosException {
ConfigurationFactory.reload();
ConfigurationCache.clear();
FILE_CONFIG = ConfigFactory.load("registry-test.conf");
- configService =
NacosFactory.createConfigService(NacosConfiguration.getConfigProperties());
+ // 创建Mock对象
+ configService = Mockito.mock(ConfigService.class);
}
@Test
- @EnabledOnOs(OS.LINUX)
Review Comment:
I recommend avoiding mock-based testing here. Please make it possible to run
this as an integration test in an appropriate environment, following the
example of the RedisQueryConsolTest class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
