YongGoose commented on code in PR #7586:
URL: https://github.com/apache/incubator-seata/pull/7586#discussion_r2383768742
##########
common/src/main/java/org/apache/seata/common/util/Http2ClientUtil.java:
##########
@@ -35,9 +35,9 @@
import java.util.Map;
import java.util.concurrent.TimeUnit;
-public class Http5ClientUtil {
+public class Http2ClientUtil {
Review Comment:
At first, what I considered was abstraction through an `interface`.
I thought it would be good to dynamically select the class at runtime via
abstraction, but since the method return values of the http2 and http utility
classes are different, that turned out to be impossible.
So for now, I also think a factory class is the best option. However,
unifying the APIs of the two utility classes seems difficult at this point due
to differences in their internal logic.
It might be a good idea to revisit this after you finish the work on #7561.
In the meantime, I’ll try to work on this PR over the weekend and wrap it up
as quickly as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
