jongmin-chung commented on code in PR #7644:
URL: https://github.com/apache/incubator-seata/pull/7644#discussion_r2426870209
##########
pom.xml:
##########
@@ -234,38 +234,18 @@
</profile>
<!-- profile: spotless -->
<profile>
- <id>jdk9-jdk11-spotless</id>
+ <id>jdk17-spotless</id>
<activation>
- <jdk>[1.8, 11)</jdk>
+ <jdk>[17,)</jdk>
</activation>
<properties>
- <palantirJavaFormat.version>1.1.0</palantirJavaFormat.version>
- </properties>
- </profile>
-
- <profile>
- <id>jdk11-jdk21-spotless</id>
- <activation>
- <jdk>[11, 21)</jdk>
- </activation>
- <properties>
- <palantirJavaFormat.version>2.28.0</palantirJavaFormat.version>
- </properties>
- </profile>
-
- <profile>
- <id>jdk21-spotless</id>
- <activation>
- <jdk>[21,)</jdk>
- </activation>
- <properties>
- <palantirJavaFormat.version>2.39.0</palantirJavaFormat.version>
+ <palantirJavaFormat.version>2.74.0</palantirJavaFormat.version>
</properties>
</profile>
<profile>
- <id>java11+</id>
+ <id>java17+</id>
<activation>
- <jdk>[11,)</jdk>
Review Comment:
> I'm sorry for responding to your review too late.
>
> When I went on a long trip to Europe, I couldn't do the work because I
couldn't take my laptop.
To. @YongGoose
As you said, spotless is supported only for the version of spotless Java 17
or higher, so it seems that it is possible to remove the content that is
applied to each profile differently from the previous one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
