YongGoose commented on code in PR #7684:
URL: https://github.com/apache/incubator-seata/pull/7684#discussion_r2432494007
##########
common/src/main/java/org/apache/seata/common/http/Http1HttpExecutor.java:
##########
@@ -54,6 +58,25 @@ public class HttpClientUtil {
private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();
+ public static volatile Http1HttpExecutor instance;
+
+ /**
+ * Gets instance.
+ *
+ * @return the instance
+ */
+ public static Http1HttpExecutor getInstance() {
+
+ if (instance == null) {
+ synchronized (Http1HttpExecutor.class) {
+ if (instance == null) {
+ instance = new Http1HttpExecutor();
+ }
+ }
+ }
+ return instance;
+ }
Review Comment:
Why does this instance need to be a singleton?
##########
discovery/seata-discovery-namingserver/src/main/java/org/apache/seata/discovery/registry/namingserver/NamingserverRegistryServiceImpl.java:
##########
@@ -230,8 +227,9 @@ public void doRegister(Instance instance, List<String>
urlList) throws Retryable
}
header.put(HTTP.CONTENT_TYPE,
ContentType.APPLICATION_JSON.getMimeType());
- try (CloseableHttpResponse response = HttpClientUtil.doPost(url,
jsonBody, header, 3000)) {
- int statusCode = response.getStatusLine().getStatusCode();
+ try {
+ HttpResult httpResult =
Http1HttpExecutor.getInstance().doPost(url, jsonBody, header, 3000);
Review Comment:
It feels awkward to retrieve an object through the implementation’s
getInstance() when we already have an abstraction.
##########
common/src/main/java/org/apache/seata/common/http/HttpExecutorFactory.java:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.seata.common.http;
+
+import org.apache.seata.common.loader.EnhancedServiceLoader;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class HttpExecutorFactory {
+
+ private static final Logger LOGGER =
LoggerFactory.getLogger(HttpExecutorFactory.class);
+
+ private static final String HTTP1_IMPL = "Http1";
+ private static final String HTTP2_IMPL = "Http2";
+ private static final HttpExecutor INSTANCE = createInstance();
+
+ private HttpExecutorFactory() {}
+
+ private static HttpExecutor createInstance() {
+ String implName = isOkHttpAvailable() ? HTTP1_IMPL : HTTP2_IMPL;
+ return EnhancedServiceLoader.load(HttpExecutor.class, implName);
+ }
+
+ private static boolean isOkHttpAvailable() {
+ try {
+ Class.forName("okhttp3.OkHttpClient", false,
HttpExecutorFactory.class.getClassLoader());
+ return true;
+ } catch (ClassNotFoundException ignored) {
+ LOGGER.warn("HTTP2 implementation not available in classpath,
falling back to default executor!");
+ return false;
+ }
+ }
Review Comment:
What is it used for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
