kssumin commented on PR #7674:
URL: https://github.com/apache/incubator-seata/pull/7674#issuecomment-3418358211
> @kssumin
>
> Where did you handle the `channelInactive` event?
The `channelInactive()` event handler **already exists** in
`AbstractNettyRemotingServer`
(before this PR). I didn't modify it - instead, I integrated the TM
disconnect logic into
the existing `handleDisconnect()` method that `channelInactive()` calls.
**Event flow**:
channelInactive() [existing code]
↓
handleDisconnect() [existing method, I added TM logic here]
↓if (TMROLE) → tmDisconnectHandler.handleTMDisconnect()
The commit diff doesn't show `channelInactive()` because I didn't change
it.
The new logic is in `handleDisconnect()` at line 226-233.
Would you like me to add a code comment to make this flow more explicit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]