chuzhe-as-a-dev commented on code in PR #7509:
URL: https://github.com/apache/incubator-seata/pull/7509#discussion_r2480145849


##########
rm-datasource/src/main/java/org/apache/seata/rm/datasource/xa/ConnectionProxyXA.java:
##########
@@ -161,6 +163,7 @@ public void xaRollback(String xid, long branchId, String 
applicationData) throws
      * @throws XAException XAException
      */
     public void xaRollback(XAXid xaXid) throws XAException {
+        xaEnd(xaXid, XAResource.TMFAIL);

Review Comment:
   Hi! Can you explain a bit why this `xaEnd()` is added?
   
   I'm experiencing issues with this line ending a MySQL branch, where the DB 
throws an exception saying that end is not allowed when the branch is in a 
NON-EXISTING state.
   Without this line, everything works just fine since Seata 2.0.0.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to