Copilot commented on code in PR #7688:
URL: https://github.com/apache/incubator-seata/pull/7688#discussion_r2513834763
##########
compatible/src/main/java/io/seata/integration/http/JakartaTransactionPropagationInterceptor.java:
##########
@@ -21,4 +21,4 @@
*/
@Deprecated
public class JakartaTransactionPropagationInterceptor
Review Comment:
JakartaTransactionPropagationInterceptor has the same name as its supertype
[org.apache.seata.integration.http.jakarta.JakartaTransactionPropagationInterceptor](1).
```suggestion
public class JakartaTransactionPropagationInterceptorCompat
```
##########
compatible/src/main/java/io/seata/integration/http/JakartaSeataWebMvcConfigurer.java:
##########
@@ -20,4 +20,5 @@
* The type Jakarta seata web mvc configurer.
*/
@Deprecated
-public class JakartaSeataWebMvcConfigurer extends
org.apache.seata.integration.http.JakartaSeataWebMvcConfigurer {}
+public class JakartaSeataWebMvcConfigurer
Review Comment:
JakartaSeataWebMvcConfigurer has the same name as its supertype
[org.apache.seata.integration.http.jakarta.JakartaSeataWebMvcConfigurer](1).
##########
compatible/src/test/java/io/seata/integration/http/JakartaSeataWebMvcConfigurerTest.java:
##########
@@ -51,7 +51,7 @@ public void testConstructor() {
public void testInstanceOfApacheSeataClass() {
JakartaSeataWebMvcConfigurer configurer = new
JakartaSeataWebMvcConfigurer();
assertTrue(
- configurer instanceof
org.apache.seata.integration.http.JakartaSeataWebMvcConfigurer,
+ configurer instanceof
org.apache.seata.integration.http.jakarta.JakartaSeataWebMvcConfigurer,
Review Comment:
There is no need to test whether an instance of
[JakartaSeataWebMvcConfigurer](1) is also an instance of
[JakartaSeataWebMvcConfigurer](2) - it always is.
##########
compatible/src/test/java/io/seata/integration/http/JakartaTransactionPropagationInterceptorTest.java:
##########
@@ -51,7 +51,8 @@ public void testConstructor() {
public void testInstanceOfApacheSeataClass() {
JakartaTransactionPropagationInterceptor interceptor = new
JakartaTransactionPropagationInterceptor();
assertTrue(
- interceptor instanceof
org.apache.seata.integration.http.JakartaTransactionPropagationInterceptor,
+ interceptor
+ instanceof
org.apache.seata.integration.http.jakarta.JakartaTransactionPropagationInterceptor,
Review Comment:
There is no need to test whether an instance of
[JakartaTransactionPropagationInterceptor](1) is also an instance of
[JakartaTransactionPropagationInterceptor](2) - it always is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
